SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
552 stars 89 forks source link

Shortcut to edit Song Transpose number of semitones interferes with scrolling + instant mutes workflow #2112

Closed soymonitus closed 1 month ago

soymonitus commented 1 month ago

Please describe the problem:

While performing in row mode, i am used to do scrolling through the rows and doing instante mute/unmute actions (shift + mute pads). While holding Shift to be quicker to mute/unmute, I can't scroll like before because instead of scrolling the Deluge changes the TRANSPOSE number of semitones for the new global transpose feature

What is the expected behavior?

Instead of using shortcut "SHift + Up/Down encoder", I suggest moving it to "Shift + hold and turn up/down encoder"(currently unused), keeping the existing "Hold and turn up/down encoder" to do the actual transpose action, so it doesn't interfere with scrolling and having shift engaged for instant mute/unmutes

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

other

What is the firmware name:

1.1 beta

If possible provide the steps to reproduce the issue and upload additional media:

No response