SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
564 stars 93 forks source link

Undo in kit clip can make gold knobs affect the incorrect row #2141

Closed ok-reza closed 3 weeks ago

ok-reza commented 3 months ago

Please describe the problem:

If you are undoing an action in a kit clip, and the undo makes another row active, the gold knobs will affect the last active kit row prior to the undo instead of the visually active row.

This occurs in official 4.1.4 as well.

What is the expected behavior?

Once an undo makes another kit row active, the gold knobs (and anything else) should pertain to affecting only the active row.

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED, 7SEG

What firmware did you reproduce it with?

other

What is the firmware name:

v4.1.4 to c1.1

If possible provide the steps to reproduce the issue and upload additional media:

https://github.com/SynthstromAudible/DelugeFirmware/assets/136033640/06564fc2-8830-436e-a30b-d9a947744bc5