search

SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
564 stars 93 forks source link

The next installment of the reforms of the Storage Manager #2148

Closed jamiefaye closed 1 month ago

jamiefaye commented 3 months ago

In which we split the StorageManager.cpp into 3 files. We also are slowly eliminating "globalism" by allowing multiple Serializers and Deserializers to co-exist. The writeJsonFlag controls which file format we save in. RIght now it is bool const = false which may allow some of the code to be stripped away.

github-actions[bot] commented 3 months ago

Test Results

102 tests  ±0   102 :white_check_mark: ±0   0s :stopwatch: ±0s  15 suites ±0     0 :zzz: ±0   15 files   ±0     0 :x: ±0 

Results for commit 5418e003. ± Comparison against base commit bb234736.

:recycle: This comment has been updated with latest results.

seangoodvibes commented 3 months ago

First comment:

I see use of both f_close and closeFile. I think we should be consistent and use one or the other and not both?