SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
551 stars 88 forks source link

Velcoity and Modwheel latches a to 127 value when reentering them while the column's momentary setting is disabled #2155

Closed ok-reza closed 2 weeks ago

ok-reza commented 2 weeks ago

Please describe the problem:

1.1 RC-3

Sidebar latching seems to be resolved if the column's settings is set to Momentary Enabled (Defaults > UI > Keyboard > Sidebar Control > Momentary > Enabled).

However, this isn't the case when the velocity or modhweel sidebars have Momentary set to Disabled. When you switch the sidebar mode, things are fine, but when you wrap back around to the either velocity or modwheel sidebar mode, upon release, it will be latched to the top pad's value of 127.

What is the expected behavior?

When reentering a sidebar mode of velocity or modwheel (while momentary is disabled in settings), it shouldn't latch to a value of 127.

Is there a relevant Pull request?

2116

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

other

What is the firmware name:

1.1 RC3

If possible provide the steps to reproduce the issue and upload additional media:

  1. Set sidebars to disabled for Momentary Velocity and Momentary Modwheel: (Defaults > UI > Keyboard > Sidebar Control > Momentary Velocity (and/or Modhweel)> Enabled).

  2. Enter Synth Keyboard View

  3. Press the topmost pad for velocity and turn <> to switch keyboard mode

  4. You can audition pads now and note that no velocity change is occurring

  5. Switch the sidebar back to velocity.

  6. Upon release, note that the top most pad is now lit

  7. You can audition pads now and note that velocity has increased.