search

SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
551 stars 88 forks source link

Beta 1.1, Midi follow is sending data in Song View affect entire #2164

Closed soymonitus closed 1 week ago

soymonitus commented 2 weeks ago

Please describe the problem:

While in Song or Grid view with affect entire engaged, I expect the LPF freq knob to not send data to midi follow, but it is sending midi CC 74 through the midi follow channel i have set up (even if i learn the Song's LPF Freq param to a different CC using the Song menu).

What is the expected behavior?

Affect entire Song/Grid view should not send midi follow CC's out of the Deluge when moving the golden knobs, because those knobs are meant to control the song global fx and not the selected clip sound

Is there a relevant Pull request?

1.1

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

Built from community

What is the firmware name:

No response

If possible provide the steps to reproduce the issue and upload additional media:

No response

seangoodvibes commented 2 weeks ago

Confirmed bug from removing midi follow control of song params and not taking that into account with the midi follow feedback.

Need to fix this before we release 1.1. Shouldn't be too difficult.