SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
551 stars 88 forks source link

exit UIs on long press back #2166

Closed m-m-adams closed 1 week ago

m-m-adams commented 2 weeks ago

Implements long press back to exit menus as a fast and consistent everywhere alternative to pressing the sidebar as mentioned in #2027

  1. Make exitUI a virtual function in UI rather than separate per class functions

  2. When back is pressed start a timer to exit the current UI

  3. UIs can exit on long press back by implementing exitUI. Currently the following UIs exit (basically everything that has an instant exit ability already)

Also reduces the long hold from 500 to 400 - this feels good for the existing long press functions and 500 felt too long for holding back to exit. Open to putting that back though

github-actions[bot] commented 2 weeks ago

Test Results

46 tests  ±0   46 :white_check_mark: ±0   0s :stopwatch: ±0s  8 suites ±0    0 :zzz: ±0   8 files   ±0    0 :x: ±0 

Results for commit 017101b9. ± Comparison against base commit 50a0cbac.

:recycle: This comment has been updated with latest results.

seangoodvibes commented 2 weeks ago

This works really well. Love this. Can we add an entry to change log and community features (general improvements) for this?