SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
564 stars 93 forks source link

Bugfix/latch velocity modwheel #2170

Closed github-actions[bot] closed 3 months ago

github-actions[bot] commented 3 months ago

Fix a bug where releasing a pad recalculated the display value, leading to changes when the display value was different between calculations. Now releasing always latches the value set during the press.

Fix a bug where releasing the top pad after changing columns caused the new column to treat that as a release. Fixed by setting that pad as "dead" when it's used to change columns so no release is processed

Fix #2155

Fix velocity column initialization to make display match the held value

Fix #2156 (just the definitely buggy part)

github-actions[bot] commented 3 months ago

Test Results

9 tests   9 :white_check_mark:  0s :stopwatch: 2 suites  0 :zzz: 2 files    0 :x:

Results for commit 426171c9.

:recycle: This comment has been updated with latest results.

m-m-adams commented 3 months ago

minor regression, scrolling over chord sidebar without ever entering it turns off the scale when it should be left unchanged

Once it's been entered it's ok to scroll over in future so I think it's an initialization bug that's coincidentally fixed in community by bfredl's state saving PR

m-m-adams commented 3 months ago

Different bug, needs to be fixed in both community and release so I'll do it separately