SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
551 stars 88 forks source link

exit UIs on long press back #2172

Closed github-actions[bot] closed 1 week ago

github-actions[bot] commented 1 week ago

Implements long press back to exit menus as a fast and consistent everywhere alternative to pressing the sidebar as mentioned in #2027

  1. Make exitUI a virtual function in UI rather than separate per class functions

  2. When back is pressed start a timer to exit the current UI

  3. UIs can exit on long press back by implementing exitUI. Currently the following UIs exit (basically everything that has an instant exit ability already)

Also reduces the long hold from 500 to 400 - this feels good for the existing long press functions and 500 felt too long for holding back to exit. Open to putting that back though

github-actions[bot] commented 1 week ago

Test Results

9 tests   9 :white_check_mark:  0s :stopwatch: 2 suites  0 :zzz: 2 files    0 :x:

Results for commit 189665a1.