search

SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
552 stars 87 forks source link

Increment this->getValue() to reflect physical CV port number #2181

Closed mnantel closed 1 week ago

seangoodvibes commented 1 week ago

Is this a fix for https://github.com/SynthstromAudible/DelugeFirmware/issues/2153?

if so, thx!

If you could add a comment in the code about why the increment is necessary that would be great!

mnantel commented 1 week ago

Comment added!

github-actions[bot] commented 1 week ago

Test Results

46 tests  ±0   46 :white_check_mark: ±0   0s :stopwatch: ±0s  8 suites ±0    0 :zzz: ±0   8 files   ±0    0 :x: ±0 

Results for commit ca32a1ab. ± Comparison against base commit 6180e295.