github-actions[bot]
commented
3 months ago Test Results
49 tests +1 49 :white_check_mark: +1 0s :stopwatch: ±0s 9 suites ±0 0 :zzz: ±0 9 files ±0 0 :x: ±0
Results for commit 9156fe19. ± Comparison against base commit 99281139.
This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
``` ValueScalingTest ‑ arpMidiCvRatchetValueScaling ``` ``` ValueScalingTest ‑ arpMidiCvRatchetOrRhytmValueScaling ValueScalingTest ‑ consistentArpAndMenuMaxValues ```:recycle: This comment has been updated with latest results.
The math is exactly the same, because NUM_PRESET_ARP_RHYTHMS must in the current state of the codebase be kMaxMenuItem+1.
Make that dependecy explicit, rename to kMaxPresetArpRhythm to get rid of extraneous - 1 calcs.
Name the shared value scaling compute(Current|Final)ValueForArpMidiCVRatchetsOrRhythm. There doesn't seem to be a real reason they are shared, and the scaling seems awkward for Rhythm: awkward name reflects that un-nicely.
Pull out the rhythm patterns into a separate header, so they don't pull in resizable array to unit tests.
Use the compute-function in arpeggiator.cpp where appropriate.