Release 1.2 - Update Midi Follow Feedback for kit drum selection

SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/

GNU General Public License v3.0

565 stars 94 forks source link

Release 1.2 - Update Midi Follow Feedback for kit drum selection #2193

Closed seangoodvibes closed 3 months ago

seangoodvibes commented 3 months ago

Added one additional scenario where Midi Follow Feedback should be sent:

when you've selected a kit clip for midi follow control and you're not currently in that kit clip (e.g. in song view), and affect entire is disabled in that kit clip, changing drum selection will necessitate sending updated midi feedback to advise controller of the changed kit drum selection context

Will create a separate PR for Release 1.1

github-actions[bot] commented 3 months ago

Test Results

48 tests ±0 48 :white_check_mark: ±0 0s :stopwatch: ±0s 9 suites ±0 0 :zzz: ±0 9 files ±0 0 :x: ±0

Results for commit 958e5559. ± Comparison against base commit 6fdee8e3.

:recycle: This comment has been updated with latest results.

m-m-adams commented 3 months ago

I don't think we should merge. Midi feedback updating sends 70 messages, if you play a simple kick/snare/hat pattern with feedback enabled it will wreck the midi link for all other uses

This should wait until we have prioritized midi