SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
565 stars 94 forks source link

Refactor clip->section into section class #2213

Closed seangoodvibes closed 3 months ago

seangoodvibes commented 3 months ago

Please describe the problem:

Each clip belongs to a section the section is identified as an integer currently as part of the clip class

In order to incorporate additional "section-wide" changes in the future, a section class should be created

Thus instead of getting the section ID as follows: clip->section

you would get it like this: clip->section->id

Once we have a section class, we can look to add modeNotes and rootNote to the section class so that we move scale from the song level down to the section level.

What is the expected behavior?

Add a section class so that we can accommodate section wide variables and information

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED, 7SEG

What firmware did you reproduce it with?

Built from community

What is the firmware name:

No response

If possible provide the steps to reproduce the issue and upload additional media:

No response