refactor: combine modeNotes and rootNote into a MusicalKey-class

SynthstromAudible / DelugeFirmware

GNU General Public License v3.0

565 stars 94 forks source link

Closed nikodemus closed 3 months ago

nikodemus commented 3 months ago

MusicalKey is mostly a POD class for now, but intent is to pull most root & scale logic from song.cpp here, as long as it can be disentangled from code dealing with song and clip structures.

github-actions[bot] commented 3 months ago

57 tests +1 57 :white_check_mark: +1 0s :stopwatch: -1s 10 suites +1 0 :zzz: ±0 10 files +1 0 :x: ±0

Results for commit 655b2bf4. ± Comparison against base commit adcfa4c8.

:recycle: This comment has been updated with latest results.

soymonitus commented 3 months ago

"Key" seems a pretty generic term for referring to the current scale. Could it me renamed to something like MusicalKey or something like that? wdyt?