define getName() for UI subclasses and add opt debug to matrixdriver

SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/

GNU General Public License v3.0

552 stars 87 forks source link

define getName() for UI subclasses and add opt debug to matrixdriver #2219

Closed mnantel closed 19 hours ago

mnantel commented 2 days ago

definitions_cxx.hpp -> #define MATRIX_DRIVER_DEBUG enables additional debug output names are the file name of the class, usually the same as the class name and the UI mode name, but lowercase debug prints out getName from UI subclass, pad x/y, velocity

the purpose of this change is to facilitate learning the code workflow

github-actions[bot] commented 2 days ago

Test Results

56 tests ±0 56 :white_check_mark: ±0 0s :stopwatch: ±0s 9 suites ±0 0 :zzz: ±0 9 files ±0 0 :x: ±0

Results for commit 1d9f2547. ± Comparison against base commit 7c05d71d.

:recycle: This comment has been updated with latest results.

mnantel commented 2 days ago

Ok, I think I am good with this PR. Lesson learnt: keep those as drafts until I am done :) Sorry about the spam and numerous commits. Live and learn!

m-m-adams commented 19 hours ago

This looks good to me. It takes up about 800 bytes for the extra strings but I think removing unused strings in release builds is probably a more general optimization we should look into