SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
571 stars 98 forks source link

Arp gate is shorter in c1.1 when ENV1 Release is set to 0 or near 0 #2268

Open ok-reza opened 4 months ago

ok-reza commented 4 months ago

Please describe the problem:

If env1 release is 0 or near 0, arp gate amount generates more choked sounding notes when compared to previous firmware.

This is most apparent when release is set to 0.

This was discovered from investigating 'SONG13G', provided by the user. Setting the arp's release to 3 or 4 unified the gate behavior between firmwares for that song.

SONG13G files: https://www.dropbox.com/scl/fo/krncct3qgqwsgh3o52jay/AHZR9RCWnariXl1gSSgHaWU?rlkey=pzjvbosak38toi6zdu5ij961c&e=1&dl=0

What is the expected behavior?

Unify arp gate between firmware versions at low release values.

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

Release 1.1/Beethoven

What is the firmware name:

c1.1

If possible provide the steps to reproduce the issue and upload additional media:

  1. Create new synth, new project, bpm 120, set ENV1 Release to 0.
  2. Enter a drone note across 1 bar
  3. Set synth Arp Mode to ON (any arp mode should do), set Arp Rate to 32nd notes
  4. Playback
  5. Set Arp Gate to lower values, like 20, 10, or 5.
  6. Resample these arps, load previous firmware, and compare them to the resampled versions.
m-m-adams commented 4 months ago

Which track in this song has the problem? There's a lot of them

ok-reza commented 4 months ago

it's one of the arp tracks, i think in arranger view it's towards the bottom, 2nd to last? if i recall it was named synt17. can confirm in a couple hours

m-m-adams commented 3 months ago

I've poured through this tonight and I don't think it's a bug, probably a result of more accurate window sizes not smearing the gate and release

Maybe we should bump up the minimum gate so it always at least starts a note?