SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
560 stars 93 forks source link

Previewing resamples being cut short #2322

Open Exmpl-xe opened 1 month ago

Exmpl-xe commented 1 month ago

Please describe the problem:

Sometimes in browser previewing resamples will cut out early while in blank song, hasn't happened with other audio folders yet. It's inconsistent

What is the expected behavior?

Preview complete sample length

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

7SEG

What firmware did you reproduce it with?

Release 1.1/Beethoven

What is the firmware name:

C1.1.0

If possible provide the steps to reproduce the issue and upload additional media:

1.power 2.create audio clip 3.shift browse & scroll to resample (possibly others) 4. Browse & listen, it's inconsistent.

m-m-adams commented 1 month ago

It looks like previewing samples just won't steal memory from the current song, so if the song is using all the memory a long sample can't load entirely

I'm not sure if fixing this would be desirable since it might have performance impacts