SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
567 stars 97 forks source link

Follow up changes for PR #1545 (Song Macros) #2414

Open seangoodvibes opened 3 months ago

seangoodvibes commented 3 months ago

Please describe the problem:

What is the expected behavior?

See above

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

Built from community

What is the firmware name:

No response

If possible provide the steps to reproduce the issue and upload additional media:

No response

bfredl commented 3 months ago

Solution: move it up and change its colour to yellow

I thought about this, but as the YELLOW mode was not actually removed from the enum, I thought it was reserved for future use.

seangoodvibes commented 3 months ago

Solution: move it up and change its colour to yellow

I thought about this, but as the YELLOW mode was not actually removed from the enum, I thought it was reserved for future use.

Ah that was just a mistake

Yellow mode was just removed recently so I prob forgot that part