SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
565 stars 94 forks source link

Pressing enter while saving a kit without typing a name doesn't save anything #2658

Open bukru opened 2 weeks ago

bukru commented 2 weeks ago

Please describe the problem:

In a kit, press [AUDITION] pad + [Midi] to convert the row in midi row and then choosing midi channel and note with gold knobs. Save the kit.

When reloading the kit the configuration is lost.

What is the expected behavior?

The configuration should be saved with the kit.

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

Release 1.1/Beethoven

What is the firmware name:

No response

If possible provide the steps to reproduce the issue and upload additional media:

In a kit, -press [AUDITION] pad + [Midi] to convert the row in midi row -then choosing midi channel and note with gold knobs. -Save the kit.

seangoodvibes commented 2 weeks ago

Midi isn't saved with presets, it's saved with the song. This is a bigger issue.

bukru commented 2 weeks ago

Thanks for answer,

Is it possible to copy/paste a clip and his midi configuration from a song to another ?

m-m-adams commented 2 weeks ago

@seangoodvibes Midi drums are still saved in the kit and I think that's what's being described

I can't reproduce this though. Midi rows in my kits are loading fine

seangoodvibes commented 2 weeks ago

@seangoodvibes Midi drums are still saved in the kit and I think that's what's being described

I can't reproduce this though. Midi rows in my kits are loading fine

ah yea that works fine for me too.

bukru commented 2 weeks ago

Thanks to all of you as always for your support :+1:

So i retry the stuff, and as you say me it work fine for you i searched what i did wrong and ... i think i found it !

When saving :

As a conclusion : i was thinking to save the kit, but actually not.

Now i know it but i think i will do this error sometimes again.

bukru commented 2 weeks ago

Do you think i should post an other issue for that or i just close the thread ?

seangoodvibes commented 1 week ago

Do you think i should post an other issue for that or i just close the thread ?

So if I'm understanding correctly, what you're saying is that when you press enter to overwrite an existing kit, it's not saving your midi changes into that overwritten kit. I can test that

Update: seems to work for me!

bukru commented 1 week ago

Actually i think it save nothing in that situation

bukru commented 1 week ago

When saving :

< save > + < kit > (ok)

select with < select > knob OR write a name with keyboard (ok)

and then here is it :
IF you write a new name then press "enter" **with the keyboard layout** (the green "key" on the right), it saved the new kit

**BUT IF** you select a existing kit, then press "enter" **with the keyboard layout  (the green "key" on the right)**, it will ask for "overwrite ?", then press "enter" again  **(the green "key" on the right)**, and it will do nothing actually, just close the popup

do you want me to make a video ?