SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
568 stars 98 forks source link

Audition pads stay lit when editing non-playing clip #2897

Open RJ-Eckie opened 2 weeks ago

RJ-Eckie commented 2 weeks ago

Please describe the problem:

In song mode, when editing a clip that is not playing and using the audition pads, the pads stay lit after releasing them.

What is the expected behavior?

When releasing an audition pad, pad should return to being unlit

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

Built from community

What is the firmware name:

No response

If possible provide the steps to reproduce the issue and upload additional media:

Song View (either layout,) create a track with multiple clips Arm one of the clips for playing Press play Edit a clip that is not playing Use the audition-pads to audition sounds

m-m-adams commented 1 week ago

I can't reproduce this - I followed the steps and the pads are correctly dimming after I release

RJ-Eckie commented 1 week ago

I can't reproduce this - I followed the steps and the pads are correctly dimming after I release

Ok let me try what versions this is does/doesn't occur on and I'll post a video of the results

RJ-Eckie commented 1 week ago

It looks like this only happens in kits. I've been able to reproduce this back to release v1.1 (current downloadable build). Not in official. Issue only occurs when playing

https://github.com/user-attachments/assets/23d8b412-60d2-4ce4-a9a0-aafc2f4b29f8

m-m-adams commented 1 week ago

Putting this as future release - we've already released firmware with this bug so I don't think it should hold up releasing 1.2

That said if there's a fix we should bring it to 1.2 as well