SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
568 stars 97 forks source link

Line in OSC automation issue as drawing previews strange pitch #820

Closed rpc9943 closed 8 months ago

rpc9943 commented 11 months ago

Please describe the problem:

Drawing pitch automation on line in OSC changes the pitch as I am drawing a line in, to a pitch not matching the automation and releases as I let go.

What is the expected behavior?

To it not changing the pitch when I draw automation. After I released the pads from this it doesn't even match the automation that it made as I enter in.

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

Release 1.0/Amadeus

What is the firmware name:

Amadeus 1.0

If possible provide the steps to reproduce the issue and upload additional media:

  1. Set up line in OSC
  2. Go to pitch automation
  3. Enter in lines and hear the pitch changes as I'm entering the line even if cursor is not on the area I'm entering, at a pitch that does not match the automation I'm entering in. After release the drawing of lines of pads, the pitch returns to the correct automation
sapphire-arches commented 11 months ago

Repro'd, it sounds like what's happening is we're immediately applying the tapped automation value which is then reset to the value under the playhead when the playhead crosses another automation node. This is probably what we want when the playhead is stopped but not when the transport is running.

m-m-adams commented 9 months ago

Related - I noticed applying automation to local parameters while a note is held and playback is stopped stops the note

m-m-adams commented 8 months ago

Fixed