search

SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
568 stars 97 forks source link

Launching clips does not respect longest clip length playback before switching. #822

Closed ok-reza closed 11 months ago

ok-reza commented 11 months ago

Please describe the problem:

Queueing songs to launch in any Song view will switch songs based on the shortest clip currently playing finishing instead of the longest.

What is the expected behavior?

The longest clip of currently playing clips should play all the way through before switching to any queued-to-launch clips.

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED, 7SEG

What firmware did you reproduce it with?

Release 1.0/Amadeus

What is the firmware name:

c1.0.0

If possible provide the steps to reproduce the issue and upload additional media:

  1. Make a synth clip of 2 bars, sequence notes.
  2. Make a drum clip of 1 bar, sequence notes.
  3. Make a third synth clip, sequence notes.
  4. Make the first 2 clips one section color; blue, make the third a different section color; pink.
  5. Mute pink and only play blue.
  6. Before the first bar has finished, hit the pink launch pad; The pink clip will launch at the end of bar 1 instead of the end of the longest clip (in this case 2 bars).
ok-reza commented 11 months ago

Nevermind, it seems like these rules are different when using Section Launching vs Mute launching and this is expected behavior!