SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
568 stars 97 forks source link

Cannot rename instruments in Arranger view via NAME shortcut (7SEG only) #823

Closed ok-reza closed 7 months ago

ok-reza commented 11 months ago

Please describe the problem:

It seems renaming is blocked on 7SEG in Arranger view. The keyboard shows up but no input is allowed.

What is the expected behavior?

To be able to rename songs. This may be an oversight with OLED/7SEG behavior on the same firmware?

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

7SEG

What firmware did you reproduce it with?

Release 1.0/Amadeus

What is the firmware name:

c1.0.0

If possible provide the steps to reproduce the issue and upload additional media:

Open a previous song or start a new one. Enter Arranger mode Hold Audition Pad of a given instrument + hit NAME shortcut. Keyboard appears, no input received.

m-m-adams commented 11 months ago

On one hand this is a bug, on the other hand renaming instruments breaks the synth preset loading logic in both community and official. So while this is probably fixable we should fix loading first

lburygin commented 11 months ago

Actually you can rename, try to just type your instrument name and press enter. It is just the letters you typing don't show up on the screen, that's a bug, I found it too recently

vcastellm commented 11 months ago

Same here, renaming works but it's not displayed.

sapphire-arches commented 10 months ago

We should fix the display issue for 1.1, though we probably can't fix the browser bugs before then....