Syphdias / i3-chrome-tab-dragging

This floats chrome windows with i3wm while dragging tabs.
MIT License
42 stars 4 forks source link

It doesn't work for me #4

Closed htn274 closed 2 years ago

htn274 commented 2 years ago

image I am very appreciate for your work cause it is very helpful for me if it would work. This is my screenshot for i3 config. I don't know why it does not work. I hope to have your help. Thank you!

Syphdias commented 2 years ago

Did you install the requirements? pip install --user -r requirements.txt

Also, could you try running ~/.config/i3/i3-chrome-tab-dragging.py directly in the commandline to see any errors?

htn274 commented 2 years ago

ezgif com-gif-maker It doesn''t show any error. So I don't know what is happening :<

Syphdias commented 2 years ago

So I think we need to talk a bit more precise. The problem this script is supposed to solve is, that if you take one tab ob Google Chrome while using the i3wm it instantly resizes the dragged tag to a tiling window. This means that is takes up half the space of in a usual configuration.

The script listens for new Chrome window events and if at this time the (left) mouse button is pressed, it switches the window to floating. You can then drag the window as you normally would. In your demonstration it looks like this is working fine.

If you release the window that was just created, it will go back to non-floating, unless it does not exist anymore. This happens if you move it into another Google Chrome window. It looks like this is what is not working correctly right? Can you make sure you see the tab in the window before letting go of the mouse button?

tjb0607 commented 2 years ago

this is an upstream issue that has nothing to do with this script, a recent update somehow broke all drag and drop functionality in Chrome in i3 and it seems like htn274 was hoping this script could fix that issue. Unfortunately, this script is a fix for a completely different issue.

Syphdias commented 2 years ago

Yup, I can now (unhappily) say, that I have the same issue.

My Chromium is still on version 96; here the dragging is broken in a way this script can workaround it. My Google Chrome is on version 97; here it is broken the way ~you~ we experience.

I didn't search for a chromium issue yet?

PS: Actually dragging windows used to work in version 83 of chromium/chrome and somehow it broke...

Syphdias commented 2 years ago

https://bugs.chromium.org/p/chromium/issues/detail?id=1286852&q=drag&can=2

Edit: This is just one of many issues you find if you search the bugtracker for "drag" Edit2: This seems to be the main one: https://bugs.chromium.org/p/chromium/issues/detail?id=1279532

htn274 commented 2 years ago

Thank you for your support. I have changed to Firefox recently :laughing:
I think the issue is from chrome not from your code. But I wonder can I downgrade the google chrome? :thinking:

Syphdias commented 2 years ago

I'll close this issue but leave it pinned, just in case someone stumbles into the same issue.

I also added to the README at the top after the deprecation warning which versions broke stuff.

cseyda commented 2 years ago

Version 97.0.4692.99 of Chromium fixed the drag problem for me

Syphdias commented 2 years ago

"Fixed". Let's just say it makes sense to use this repo/script/tool again. To recap:

ekzyis commented 2 years ago

Mhh, can you confirm it is still working? Going into floating mode on dragging seems to work but the tab does not dock into the other window for some reason.

I am using Google Chrome Version 102.0.5005.61 (Official Build) (64-bit) with i3 version 4.20.1 (2021-11-03) and 5.10.117-1-MANJARO.

Thanks for your work btw!

tjb0607 commented 2 years ago

there was an upstream regression (https://bugs.chromium.org/p/chromium/issues/detail?id=1279532#c162) which specifically affects i3, a fix is on the way (https://chromium.googlesource.com/chromium/src/+/95b94a2b841b624be8c0c99730f7011aa56a6a60) but you have to wait for the next chrome release

Syphdias commented 2 years ago

Unfortunately, the issue has been fixed (partly) multiple times now before getting broken again. :disappointed: