SysBioChalmers / GECKO

Toolbox for including enzyme constraints on a genome-scale model.
http://sysbiochalmers.github.io/GECKO/
MIT License
64 stars 46 forks source link

refactor: FSEOF #356

Closed ae-tafur closed 7 months ago

ae-tafur commented 9 months ago

Main improvements in this PR:

FSEOF implementation in GECKO 2 in summary fix % of the maximum growth and forced the rest of the carbon source towards product target. Nevertheless, original implementation (https://doi.org/10.1128/AEM.00115-10), same as RAVEN have, is the opposite. A maximum theoretical product is calculated, then this value is fixed to a different % of it, to further maximize the growth. Then, here FSEOF implementation is refactored to follow same as RAVEN since the cell will always have growth as objective.

Now:

Instructions on merging this PR:

github-actions[bot] commented 9 months ago

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 
Running geckoCoreFunctionTests
Done geckoCoreFunctionTests
__________

Note: In the case of multiple test runs, this post will be edited.

ae-tafur commented 9 months ago

as suggested by @edkerk, gene essentially now is considered if growth is < 1e-8.