SysBioChalmers / Human-GEM

The generic genome-scale metabolic model of Homo sapiens
https://sysbiochalmers.github.io/Human-GEM-guide/
Creative Commons Attribution 4.0 International
98 stars 41 forks source link

Invalid BiGG IDs #124

Closed JonathanRob closed 5 years ago

JonathanRob commented 5 years ago

Description of the issue:

Many metabolite and reaction BiGG IDs in the association files (humanGEMMetAssoc.JSON and humanGEMRxnAssoc.JSON) are invalid, meaning they do not correspond to an ID in the BiGG database (version 1.5 at the time this issue was created).

For example, ala_L is the BiGG ID associated with L-alanine. However, the correct BiGG ID is ala__L.

This seems to have largely been due to the use of invalid BiGG IDs in Recon3D, from which many of HumanGEM BiGG IDs originated. Others are old or expired BiGG IDs, errors carried over from previous reconstructions, and other miscellaneous sources.

Regardless of the cause, all BiGG IDs in the model annotation files should either be valid, or removed.

Expected feature/value/output:

Association files with 100% valid metabolite and reaction BiGG IDs.

Current feature/value/output:

Based on comparison with BiGG database v1.5:

I hereby confirm that I have:

haowang-bioinfo commented 5 years ago

@JonathanRob how many invalid BiGG ids were found here, if you have the specific numbers?

JonathanRob commented 5 years ago
haowang-bioinfo commented 5 years ago

Since the BiGG database content has been continuously changing and regularly updated, it would be better to explicitly indicate the database version currently being used onto the issue description, together with these invalid numbers.

JonathanRob commented 5 years ago

Good point. I have updated the description to include the database version (1.5) as well as the numbers I provided above.

JonathanRob commented 5 years ago

These BiGG ID updates have now been implemented (PR #135), so this issue can be considered solved.