Closed edkerk closed 8 months ago
Awesome!
Just to note that some of the previous reaction names contained morphological metadata ("in hepatic vein", "in lumen", "in bile"). Perhaps some of this could be moved to the
rxnNotes
field.
This might have been defined as such when first generating the model, but this information is never used to define tissue-specific functions (this is based on (f)tINIT
), and not consistently done for all exchange reactions. Also, there are no duplicate exchange reactions: there are no seperate exchange reactions for e.g. "glucose exchange in hepatic vein" and "glucose exchange in myocytes" (and this also should not be the case!). I see therefore no purpose for retaining such legacy phrases in some reaction names.
Main improvements in this PR:
Contributing towards #181, names of exchange reactions are not ambiguous and can therefore directly be defined by the metabolite that they exchange. In 1.8.1, 469/1658 exchange reactions had no name.
Instead of only filling in the empty exchange reaction names, I redefined it for all exchange reactions, for consistency, but from the diff it also becomes clear that this fixes some previously unnecessarily complex names
Code:
Example of non-empty reaction name that was changed:
MAR01986
I hereby confirm that I have:
develop
as a target branch