SysBioChalmers / Sco-GEM

The consensus GEM for Streptomyces coelicolor -
https://sysbiochalmers.github.io/Sco-GEM/
Creative Commons Attribution 4.0 International
3 stars 7 forks source link

chore: add model id #128

Closed sulheim closed 3 years ago

sulheim commented 3 years ago

Description of the issue:

I'm tired of getting the warning: '' is not a valid SBML 'SId'. every time I read in Sco-GEM. As dash ("-") is not valid SBML I suggest to add the id Sco_GEM

Expected feature/value/output:

No error message.

Reproducing these results:

If applicable, please attach any code used below (if it's matlab code replace the word "python" with "matlab".

cobra.io.read_sbml_model("Sco-GEM.xml")

To do:

If specific curations are proposed, generate a list of checkboxes of steps that should be followed to solve this issue:

I hereby confirm that:

edkerk commented 3 years ago

I suggest we append the version number: "Sco_GEM_v1.2.1", increaseVersion.py can then increase this with each release (see #118)

edkerk commented 3 years ago

Model version should only be included in the master branch, as intermediate models in the devel and child branches would not correspond to that version number anymore. So will add the model ID without versioning in devel and start including the version number when making release v1.3.0.

sulheim commented 3 years ago

Sounds good