search

SysBioChalmers / ecModels

A container for all enzyme constrained models created by GECKO.
Creative Commons Attribution 4.0 International
10 stars 6 forks source link

Create GEM-specific PRs when changes are introduced into the ecModels repository files #57

Open IVANDOMENZAIN opened 3 years ago

IVANDOMENZAIN commented 3 years ago

In the current implementation of the automated workflow, the GECKO pipeline is programmed to run exclusively on GEMs whose version has changed,or for all models if any of the dependencies changes its version. This situation will eventually make that, when changes are introduced into any file in this repository, GEM-specific PRs are not gonna be created because a change in the source model version are not taking place.

Therefore, we need that our pipeline is able to run and create PRs for a model, every time that:

mihai-sysbio commented 3 years ago

For even more accuracy, I'd consider rephrasing

or for all models if GECKO changes its version

to

or for all models if any of the dependencies changes its version.

mihai-sysbio commented 3 years ago
  • [ ] A change in the source model version is detected by a scheduled run.

I think this is already implemented - every time the latest tag changes, the pipeline is triggered, see here.

  • [ ] When changes in the GECKO toolbox are detected by a scheduled run (new release).

This is already implemented here.

Therefore, I think this issue is solved and it can be closed.