SysBioChalmers / ecModels

A container for all enzyme constrained models created by GECKO.
Creative Commons Attribution 4.0 International
10 stars 6 forks source link

fix/parse_matlab_version #59

Closed IVANDOMENZAIN closed 3 years ago

IVANDOMENZAIN commented 3 years ago

This PR solves a bug in the MATLAB version parsing step in the ecModels update pipeline. It has been detected that MATLAB version strings are composed of several parts: version_id + release_id + update_#. Depending on the version, not all strings may include the update_# part, which will return variable results if the version string, split into a list, is read in a backwards way.

The version parsing has been simplified by:

  1. Running the version MATLAB command in batch mode (commit 5ec3c86), which reduces the log output of MATLAB commands executed on a command line interface.
  2. Storing the whole version string, in order to avoid ambiguities or potential unintended results whenever a new MATLAB version is installed in the runner (commit 4cdbb66).

The new MATLAB version string can be seen here.