fix: dependabot config - Githubissues

SysBioChalmers / yeast-GEM

The consensus GEM for Saccharomyces cerevisiae

http://sysbiochalmers.github.io/yeast-GEM/

Creative Commons Attribution 4.0 International

96 stars 46 forks source link

fix: dependabot config #267

Closed edkerk closed 3 years ago

edkerk commented 3 years ago

Main improvements in this PR:

fix:
- dependabot makes monthly (if required) PR to develop instead of main
chore:
- also store gh-pages memote release workflow configuration in develop (was already in main: e778a36978c94be4db9085977ce0747dfa166806)

I hereby confirm that I have:

[X] Tested my code with all requirements for running the model
[X] Selected develop as a target branch (top left drop-down menu)
[X] If needed, asked first in the Gitter chat room about this PR

mihai-sysbio commented 3 years ago

It's unexpected that a file would end up in main without going through develop so it'a good to address that. But about the release workflow, how is that different from the other workflow in terms of purpose?

edkerk commented 3 years ago

Ah sorry, it is the workflow that makes gh-pages, I should have clarified that. And it should only run when a new version is released, will fix that in commit below.

mihai-sysbio commented 3 years ago

I'm sorry this comes in a bit late, but I'm really confused and had not the chance to get back to this earlier. What I can't figure out is the difference between the new memote_release and the previous memote-history workflows. In fact, it looks to me like the memote_release workflow overwrites what memote-history does, which is only fueling my confusing. What am I missing here?

edkerk commented 3 years ago

memote-history runs with each push, and is therefore run with each PR to show the current status. It stores a history report in history_report.html (although it is empty, but we agreed to have the workflow merged anyway).
memote_release runs with each release, which happens much more sporadic, and rather represents the status of the latest release version, not the latest devel version. It stores a snapshot report in release_report.html, which the gh-pages (https://sysbiochalmers.github.io/yeast-GEM/) links to (although the meaning of the memote report should probably be explained in 1-2 lines).

So while both run memote, they make different reports, stored in different locations, run at different triggers. Can one leave comments in a workflow yml file? Might be good to have the intention documented within the file.