Closed cheng-yu-zhang closed 1 year ago
Please see: https://github.com/SysBioChalmers/yeast-GEM/issues/303#issuecomment-1140223052, first priority is to resolve #305 and #306.
protein_location_sce.tsv
file with annotation data. Please simplify this table.bound0.xlsx
is unclear: what is meant with "bounds restricted to 0", and how is this used to curate the model?bound0.xlsx
). The same comments can be made for #315, but probably best to fix this for one organelle first.
Revisiting I think I now understand partially what this aimed to do:
protein_location_sce.tsv
is a list with GO term annotation of unknown sourcebound0.xlsx
, are these supposedly reactions that are located in the lipid droplet but they should not be? In that case, it is probably the wrong file, because the reactions are located in the peroxisome instead.Regardless, curation of compartments is still useful, but should be handled differently:
I will close this PR because it does not follow a sensible strategy to do this curation. Please feel free to open an Issue to discuss how to implement this curation, based on what data and which reactions should be changed.
Main improvements in this PR:
Try to be as clear as possible: Is it fixing/adding something in the model? Is it an additional test/function/dataset? PLEASE DELETE THIS LINE.
Correct reactions in lipid droplet baesd on protein location, which is detailed in the file "protein_location_sce.tsv". The file "bound0.xlsx" shows all the reactions whose bounds are restricted to 0.
Explanation: Check all reactions from the main branch. And take the reaction "r_0001" for example. "r_loca" refers to the location of "r_0001" accoording to the model. "r_pro" refers to the corresponding protein in the model. "all_lipid" refers to all the lipid droplet protein baesd on the file "protein_location_sce.tsv".
I hereby confirm that I have:
develop
as a target branch (top left drop-down menu)