SysBioChalmers / yeast-GEM

The consensus GEM for Saccharomyces cerevisiae
http://sysbiochalmers.github.io/yeast-GEM/
Creative Commons Attribution 4.0 International
94 stars 44 forks source link

Correction of compartment reaction——lipid droplet #314

Closed cheng-yu-zhang closed 1 year ago

cheng-yu-zhang commented 2 years ago

Main improvements in this PR:

Try to be as clear as possible: Is it fixing/adding something in the model? Is it an additional test/function/dataset? PLEASE DELETE THIS LINE.

Correct reactions in lipid droplet baesd on protein location, which is detailed in the file "protein_location_sce.tsv". The file "bound0.xlsx" shows all the reactions whose bounds are restricted to 0.

Explanation: Check all reactions from the main branch. And take the reaction "r_0001" for example. "r_loca" refers to the location of "r_0001" accoording to the model. "r_pro" refers to the corresponding protein in the model. "all_lipid" refers to all the lipid droplet protein baesd on the file "protein_location_sce.tsv".

I hereby confirm that I have:

edkerk commented 2 years ago

Please see: https://github.com/SysBioChalmers/yeast-GEM/issues/303#issuecomment-1140223052, first priority is to resolve #305 and #306.

edkerk commented 2 years ago

The same comments can be made for #315, but probably best to fix this for one organelle first.

edkerk commented 1 year ago

Revisiting I think I now understand partially what this aimed to do:

Regardless, curation of compartments is still useful, but should be handled differently:

I will close this PR because it does not follow a sensible strategy to do this curation. Please feel free to open an Issue to discuss how to implement this curation, based on what data and which reactions should be changed.