SysBioChalmers / yeast-GEM

The consensus GEM for Saccharomyces cerevisiae
http://sysbiochalmers.github.io/yeast-GEM/
Creative Commons Attribution 4.0 International
94 stars 44 forks source link

Volatile Esters & Polyphosphate Reactions #337

Closed edkerk closed 1 year ago

edkerk commented 1 year ago

This PR replaces #336, as the previous PR does not allow for additional commits by the maintainers (reason). The text below is copy-pasted from #336, authored by @uliebal.

Main improvements in this PR:

Polyphosphate reactions

Developers

I hereby confirm that I have:

edkerk commented 1 year ago

I reorganized the curation code and data files (and will write clearer instructions for future curations), correct some identifiers and made some further modifications.

Two open questions:

uliebal commented 1 year ago

thanks a lot for the improvements and adaptations!

On 04/06/2023 22:21, Eduard Kerkhoven wrote:

I reorganized the curation code and data files (and will write clearer instructions for future curations), correct some identifiers and made some further modifications.

Two open questions:

  • There are 2-methylbutyrate and isobutyrate assigned to the extracellular compartment, but there is no transport reaction across the cytoplasmic membrane, nor an exchange reaction that would allow for its net production. Is this intentional, or should such reactions be added?
  • I now assigned the volatile ester reactions to the subsystem "Other", is there another one from this list that is more suitable?

Click to show list of subsystems

  • Alanine, aspartate and glutamate metabolism
  • Alternate carbon metabolism
  • Amino sugar and nucleotide sugar metabolism
  • Arachidonic acid metabolism
  • Arginine and proline metabolism
  • Arginine biosynthesis
  • Ascorbate and aldarate metabolism
  • Ascospore biosynthesis
  • Beta-alanine metabolism
  • Biosynthesis of unsaturated fatty acids
  • Biotin metabolism
  • Butanoate metabolism
  • C5-branched dibasic acid metabolism
  • Carnitine metabolism
  • Cellular response to anaerobic conditions
  • Citrate cycle (TCA cycle)
  • Complex alcohol metabolism
  • Cyclic nucleotide metabolism
  • Cysteine and methionine metabolism
  • DNA repair
  • Dipeptidases
  • Exchange reaction
  • Fatty acid biosynthesis
  • Fatty acid degradation
  • Fatty acid ester pathway
  • Folate biosynthesis
  • Fructose and mannose metabolism
  • Galactose metabolism
  • Glutathione metabolism
  • Glycerolipid metabolism
  • Glycerophospholipid metabolism
  • Glycine, serine and threonine metabolism
  • Glycolysis / gluconeogenesis
  • Glycosylphosphatidylinositol (gpi)-anchor biosynthesis
  • Glyoxylate and dicarboxylate metabolism
  • Growth
  • Histidine metabolism
  • Inositol phosphate metabolism
  • Insect hormone biosynthesis
  • Lipoic acid metabolism
  • Lysine metabolism
  • Methylglyoxal metabolism
  • N-glycan biosynthesis
  • Nicotinate and nicotinamide metabolism
  • Nitrogen metabolism
  • One carbon pool by folate
  • Other
  • Oxidative phosphorylation
  • Pantothenate and coa biosynthesis
  • Pentose and glucuronate interconversions
  • Pentose phosphate pathway
  • Peptidyl-diphthamide biosynthetic process
  • Phenylalanine metabolism
  • Phenylalanine, tyrosine and tryptophan biosynthesis
  • Phosphatidylinositol signaling system
  • Porphyrin and chlorophyll metabolism
  • Propanoate metabolism
  • Purine metabolism
  • Pyrimidine metabolism
  • Pyruvate metabolism
  • Riboflavin metabolism
  • SLIME reaction
  • Sphingoglycolipid metabolism
  • Sphingolipid metabolism
  • Starch and sucrose metabolism
  • Steroid biosynthesis
  • Sulfur metabolism
  • Superoxide metabolism
  • Taurine and hypotaurine metabolism
  • Terpenoid backbone biosynthesis
  • Thiamine metabolism
  • Threonylcarbamoyladenosine metabolism
  • Transport [c, ce]
  • Transport [c, e]
  • Transport [c, er]
  • Transport [c, erm]
  • Transport [c, g]
  • Transport [c, gm]
  • Transport [c, lp]
  • Transport [c, m]
  • Transport [c, mm]
  • Transport [c, n]
  • Transport [c, p]
  • Transport [c, v]
  • Transport [c, vm]
  • Transport [ce, erm]
  • Transport [e, ce]
  • Transport [er, g]
  • Transport [erm, er]
  • Transport [erm, gm]
  • Transport [erm, lp]
  • Transport [erm, mm]
  • Transport [erm, n]
  • Transport [erm, vm]
  • Transport [m, mm]
  • Transport [m, v]
  • Transport [p, m]
  • Transport [vm, ce]
  • Transport [vm, gm]
  • Transport[c, e]
  • Tryptophan metabolism
  • Tyrosine metabolism
  • Ubiquinone and other terpenoid-quinone biosynthesis
  • Valine, leucine and isoleucine metabolism
  • Vitamin b6 metabolism
  • tRNA metabolism

— Reply to this email directly, view it on GitHub https://github.com/SysBioChalmers/yeast-GEM/pull/337#issuecomment-1575699209, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCWV7BX5DHDHGFRZGQ6BL3XJTU6JANCNFSM6AAAAAAY2E3WPQ. You are receiving this because you were mentioned.Message ID: @.***>

mihai-sysbio commented 1 year ago

Seeing these new contributions, I'm wondering if yeast-GEM wouldn't also benefit from allcontributors.org setup, see https://github.com/SysBioChalmers/Human-GEM#contributors - what do others think?

edkerk commented 1 year ago

@mihai-sysbio I'm not sure why the memote-run GitHub Action fails, especially as memote-history succeeds?

Anyway, I've reviewed the changes in this PR (but cannot post a review on my own PR), while the changes were originally committed as #336. I'll therefore force merge without review.

mihai-sysbio commented 1 year ago

@edkerk thanks for pinging about this. It was a good call to proceed without investigating.

The workflow runs a Python line before running Memote, to make the model Bigg compliant. This is achieved with a file code/io.py which looks like is missing from this PR but exists in branch develop. As a one-time workflow failure this is acceptable (although I don't know how this happened), but there shouldn't be failures like this in the future.