Some additional tests should probably be added/modified before merging (for example, checking if the correct configmap data key/value pair got mounted would be nice).
I modified some existing test specs but I avoided modifying too many as various tests are focused on other aspects of the chart (ie. extraSecrets_test, initContainers_test, ...)
Perhaps it would be a good idea to add a warning describing a slightly different behavior of subpath mounts - if configmaps are mounted using subPath, a pod restart will be necessary to pull any updates to the configmap. This is usually not necessary for ordinary mounts. This behavior should probably be documented as a trade-off.
I'm awaiting further input before introducing any additional changes.
Resolves the issue described in #38.
Some additional tests should probably be added/modified before merging (for example, checking if the correct configmap data key/value pair got mounted would be nice). I modified some existing test specs but I avoided modifying too many as various tests are focused on other aspects of the chart (ie.
extraSecrets_test
,initContainers_test
, ...)Perhaps it would be a good idea to add a warning describing a slightly different behavior of
subpath
mounts - if configmaps are mounted usingsubPath
, a pod restart will be necessary to pull any updates to the configmap. This is usually not necessary for ordinary mounts. This behavior should probably be documented as a trade-off.I'm awaiting further input before introducing any additional changes.