SysbeeTech / kubedeploy

Kubedeploy
https://kubedeploy.app/
Apache License 2.0
5 stars 2 forks source link

optional healthcheck probes #7

Closed btoic closed 10 months ago

btoic commented 11 months ago

When defining values for healthcheck probes, allow for the probes to be optional.

Expected Behavior

When defining values like:

healthcheck:
  enabled: true
  probes:
    livenessProbe:
      tcpSocket:
        port: http

Chart should only define livenessProbe in container spec.

Current Behavior

With the example above, chart is rendering all three probes defined in default values. Other rendered probes end up without required handler type, making the deployments fail.

Possible Solution

  1. Remove probe empty maps from default values for all containers. Will require more info in the docs
  2. create a helper function for healthchecks that can be used for all containers, iterating over the values and deploying only non empty probe maps

Steps to Reproduce (for bugs)

See the example values above

Your Environment