search

Syslifters / reptor

Other
11 stars 3 forks source link

Defect Dojo integration #158

Closed syn-4ck closed 7 months ago

syn-4ck commented 7 months ago

Hi!

Related with #157

NOTE: Please, verify the changes (It is working in my local host, but it could be great that you can modify/review/test it well). Thanks!

aronmolnar commented 7 months ago

Great, thank you. We'll do.

syn-4ck commented 7 months ago

Thanks @aronmolnar. Excelent work! Nice tool 👏

aronmolnar commented 7 months ago

Well done, thank you for your contribution.

I made a few adaptions, e.g., the DefectDojo results are paginated and there was a loop missing, and fixes. Can you try if you are able to migrate your findings with this version?

syn-4ck commented 7 months ago

Oh, my bad... Thanks for your work! I'm gonna try now, but I can't se changes... where is this changes applied?

aronmolnar commented 7 months ago

Ah, sorry - I of course, couldn't push to your fork. Changes are in this branch: https://github.com/Syslifters/reptor/tree/syn-4ck-main

syn-4ck commented 7 months ago

Perfect! Testing now :)

syn-4ck commented 7 months ago

Hi @aronmolnar, I put 4 comments in https://github.com/Syslifters/reptor/commit/cf0512b5776f8bd334e529721b047835252f7f36.

Some of this changes I can fix locally, and I put my recommendation, but I can't fix the last one: https://github.com/Syslifters/reptor/commit/cf0512b5776f8bd334e529721b047835252f7f36#r139247341

Could you help me to push the other 3 fixes and investigate the error in the last one?

Note that I think that resolving all this issues, it will be work.

Thanks for your support :)

aronmolnar commented 7 months ago

Thanks for your feedback.
Updated the branch.

Can you try out the next round?

syn-4ck commented 7 months ago

Hi @aronmolnar, working great! LGTM :).

syn-4ck commented 7 months ago

Hi @aronmolnar, is It better merge the syn-4ck-main branch?

aronmolnar commented 7 months ago

Hi @aronmolnar, is It better merge the syn-4ck-main branch?

Yes, my bad.