Syslifters / sysreptor

A customizable and powerful penetration testing reporting platform for offensive security professionals. Simplify, customize, and automate your pentest reports with ease.
https://docs.sysreptor.com
Other
1.48k stars 141 forks source link

Spell checking with LanguageTool or default browser spell checking #66

Closed noraj closed 1 year ago

noraj commented 1 year ago

I know your custom Spell Check is only included in the Professional edition but (both for community and pro version) it would be nice to be able to switch to other solution as per user preferences:

Default browser spell checking

It would be as easy as modifying the attribute spellcheck="false" for each field and have an option Enable default browser spell checking in /users/self/.

Plugin based spell checking

Software like LanguageTool or Antidote are offering advanced spell checking with a plugin. They work by default with all text fields like textareas but sometime they don't work with some WYSIWYG editor (example with EasyMDE and associated PR).

In Sysreptor, It's working on the one line fields (e.g., precondition) but not on multi-line text fields (with a WYSIWYG editor, e.g., Impact) even when setting contenteditable="true" and spellcheck="true".

aronmolnar commented 1 year ago

Thanks for this feedback.

We will implement a possibility for users to set spellcheck to true (contenteditable is already true).

It will probably be this button to enable/disable the spell check:

image

The setting will be stored in the browser's local storage and is applied to all fields.
This should make it possible to - at least - use native browser spell checking.

However, there are drawbacks for native browser spell checks (such as limited or no multi language support).

If plugin based spell checks do not work, we'd rather regard this as a bug in the plugins. The problem might be related to some markdown syntax-highlighting features we use.
We will not troubleshoot this in detail, as we provide the official spell check in SysReptor Professional.

MWedl commented 1 year ago

Implemented in https://github.com/Syslifters/sysreptor/releases/tag/2023.119