CSS parser error when using "i" in attribute selector

oferz commented 1 year ago

Describe the Bug The CSS parser reports an error when an attribute selector contains "i" at the end to indicate case-insensitive comparisson. Example: a[href^="https://" i]

To Reproduce Steps to reproduce the behavior:

Open a diff for files that contain a selector like: a[href^="https://" i]

Expected Behavior Should parse correctly.

Actual Behavior Shows the "i" as a parsing error.

SemanticDiff Version v0.8.2

VS Code Information

Version: 1.77.3 (Universal)
Commit: 704ed70d4fd1c6bd6342c436f1ede30d1cff4710
Date: 2023-04-12T09:19:37.325Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Darwin x64 21.6.0
Sandboxed: No

mmueller2012 commented 1 year ago

Thanks for the bug report. As you already found out, modifiers for attribute selectors weren't supported yet. I modified the parser to comply with the Selectors Level 4 Draft in this regard. The fix will be part of our SemanticDiff update next week, which will also include other CSS improvements :smiley:

mmueller2012 commented 1 year ago

We just released SemanticDiff 0.8.3 which should fix your bug. Can you confirm that it works for you?

oferz commented 1 year ago

Yes, that fixed it. Thanks.

Sysmagine / SemanticDiff

CSS parser error when using "i" in attribute selector #14