search

Sysmagine / SemanticDiff

Community support for SemanticDiff, the programming language aware diff for Visual Studio Code and GitHub.
https://semanticdiff.com
49 stars 0 forks source link

Repos containing a `.` do not work #19

Closed styfle closed 1 year ago

styfle commented 1 year ago

Describe the Bug Repos containing a dot (.) do not work.

To Reproduce Steps to reproduce the behavior:

  1. Visit https://app.semanticdiff.com
  2. Enter https://github.com/vercel/next.js/pull/51733
  3. Click "Go" button

Expected Behavior Show diff

Actual Behavior Error message "This URL does not belong to a GitHub PR or commit"

Link You can also see a more detail error at https://app.semanticdiff.com/vercel/next.js/pull/51733/files

{"detail":[{"loc":["path","repo"],"msg":"string does not match regex \"^[a-zA-Z0-9_-]+$\"","type":"value_error.str.regex","ctx":{"pattern":"^[a-zA-Z0-9_-]+$"}}]}

Additional Context Next.js is one of the most starred github repos.

There are several repos in the top 100 that contain a dot.

mmueller2012 commented 1 year ago

Thanks for reporting the bug. As you probably already noticed, the validation regex was missing a dot. I added it and deployed a new version. It should work now.

By the way, you won't have much luck with this particular PR because SemanticDiff doesn't support .mdx files yet.

styfle commented 1 year ago

Thanks! I'll close this one and create a new issue for mdx support.