search

Sysmagine / SemanticDiff

Community support for SemanticDiff, the programming language aware diff for Visual Studio Code and GitHub.
https://semanticdiff.com
40 stars 0 forks source link

Adding comment in GH PR and Issues #47

Open Mane-Pal opened 7 months ago

Mane-Pal commented 7 months ago

Is your feature request related to a problem? Please describe. I wanted to add semanticdiff as my default diff viewer in VS code and then use the Github PR and Issues extensions. The diff from semanticdiff is an improvement over the default diff, but i am missing the ability to add a comment to a change. For this i would have to open the diff in the default viewer and then add the comment. This kinda defeats the purpose imo of using semanticdiff as the default diff viewer.

Describe the solution you'd like I have no idea if its possible, but the ability to add comments from the semanticdiff view into the PR.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context

slackner commented 7 months ago

Hello @Mane-Pal,

Thanks for your report.

We're aware of this issue. Unfortunately, the VSCode extension API is quite limited for integrating with commenting features. The API does not support querying or adding comments, which would be required for integration with our diff viewer.

To make sure the VSCode team is aware of this issue, I've just opened a feature request in their issue tracker. Feel free to upvote to give this issue some more traction.

https://github.com/microsoft/vscode/issues/200371

Depending on your use case, you may be able to use our GitHub App. The GitHub app already supports review comments, as we were not constrained by the VSCode extension API. Note that if you use the GitHub app, the diff will be calculated on our servers, not locally.

Best Regards, Sebastian

Mane-Pal commented 7 months ago

Thank you very much for the fast response. I will go upvote the feature request, and try to poke some colleagues to do the same.

We might look in to the github integration in the new year.

-Mads

slackner commented 7 months ago

No worries. 😊️

I've reopened the issue so that other people looking for commenting features can also help upvote the VS Code feature request. The VS code feature request needs 20 upvotes within 60 days to be considered for inclusion in their backlog, so every vote counts.