search

Sysmagine / SemanticDiff

Community support for SemanticDiff, the programming language aware diff for Visual Studio Code and GitHub.
https://semanticdiff.com
40 stars 0 forks source link

Highlighting text in old file selects text in new file #51

Open MakotoE opened 6 months ago

MakotoE commented 6 months ago

Describe the Bug When I highlight text in a diff, text in both old and new files are selected.

Screenshot 2024-01-25 113322

To Reproduce Steps to reproduce the behavior:

  1. Open a diff for a file with multiple changes so that only some lines are shown. (I don't know what the feature is called but look at the screenshot.)
    • SemanticDiff is being used
  2. Highlight text on just the old file.
    • Same bug also happens if you highlight just the new file, which highlights the old file
  3. Text on the new file are highlighted as well.

Expected Behavior Only text in the old file should be highlighted. The VSCode diff does what I expect.

I'm not entirely positive if that is expected, but I don't think the current behavior is useful in any way.

Actual Behavior Text on both sides of the diff are highlighted.

Screenshots

Screenshot 2024-01-25 114748

Source Code Not relevant as it happens on any file with multiple changes.

SemanticDiff Version v0.8.8

VS Code Information Simply click Help -> About -> Copy in VS Code and paste the information:

Version: 1.85.2 (user setup)
Commit: 8b3775030ed1a69b13e4f4c628c612102e30a681
Date: 2024-01-18T06:40:10.514Z
Electron: 25.9.7
ElectronBuildId: 26354273
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.22631

Additional Context Add any other context about the problem here.

slackner commented 6 months ago

Hello @MakotoE,

Thank you for your report.

We're already aware of this issue, but haven't found the time to fix it yet.

Since it can be pretty annoying we will prioritize it, and ship a fix with the next VS Code release (if everything goes according to plan).

Best Regards, Sebastian