search

Sysmagine / SemanticDiff

Community support for SemanticDiff, the programming language aware diff for Visual Studio Code and GitHub.
https://semanticdiff.com
40 stars 0 forks source link

File path is clobbered with git hash #7

Closed worksofliam closed 1 year ago

worksofliam commented 1 year ago

When looking at diffs via the GitLens Commits view, the path to the file is messed up at the top of the diff. You can see in this image that there is a long string followed by the path to the file on the right.

image image
mmueller2012 commented 1 year ago

Thanks for the bug report. I can reproduce the issue, seems like the URL parser of the webview treats ABC in gitlens://ABC/def as path and not hostname. This will be fixed in the next release.

What surprises me a bit is that you don't have syntax highlighting. Are you using a Dev Container or a remote session?

worksofliam commented 1 year ago

No dev container or remote. It's local.

mmueller2012 commented 1 year ago

@worksofliam We just fixed a bug regarding missing syntax highlighting (not released yet). Can you let me know which VS Code theme you are using so I can verify that this fixes your issue as well?

worksofliam commented 1 year ago

@mmueller2012

GitHub Light.

mmueller2012 commented 1 year ago

We have just released SemanticDiff 0.8.2, which should fix both of the problems mentioned in this issue. Breadcrumbs should now only include the path when opening commits via GitLens, and syntax highlighting should now work correctly with third-party themes like GitHub Light.

I will close this bug report, but please let us know if it works for you.