search

SystangoTechnologies / react-native-apple-authentication

React Native apple sign in
MIT License
42 stars 25 forks source link

Fix fullName, identityToken and authorizationCode return values #12

Closed thehanimo closed 4 years ago

thehanimo commented 4 years ago

fullName was returning null on first sign up. Now, fullName is an object of which givenName and familyName will give you the fullName. Other fields of the object are usually null (Didn't come across a case where it isn't. Maybe with different scopes it could be the case.)

P.S. Should probably add a step in installation instructing people to copy RNCSignInWithAppleButton.h, RNCSignInWithAppleButton.m and RNCSignInWithAppleButtonManager.m into the project directory and into compile sources. Also, a usage towards a custom button would help too!

thehanimo commented 4 years ago

Initially thought it was only fullName that returned null. Seems like every other field has the same fate :)

amourya-systango commented 4 years ago

Initially thought it was only fullName that returned null. Seems like every other field has the same fate :)

Nice to see you are contributing here