System-T / DimSim

Apache License 2.0
120 stars 23 forks source link

Undo modifications to the license itself #9

Closed xuhdev closed 3 years ago

xuhdev commented 5 years ago

As part of the text of the Apache license v2, the apendix of the license teaches readers how to apply the license, but does not ask users to modify that part.

Similar to IBM/MAX-Image-Segmenter#32 and kubernetes/kubernetes@d30db1f9a915aa95402e1190461469a1889d92be

kmh4321 commented 5 years ago

I think this needs to be done as per the instructions at the bottom of this page: https://www.apache.org/licenses/LICENSE-2.0

xuhdev commented 5 years ago

Yes, but it is exactly the instruction itself that you have altered. The instruction has clearly stated that you should attach that part to your work, not saying that you should change the instruction itself. As a comparison, GPL also has a similar block at the end, for which it might be easier to see its purpose.

autoih commented 5 years ago

Yes, I think the part is for other people to modify.