Closed greylegboas closed 1 year ago
I've found crafted-early-init-config
actually configures MELPA, so crafted-ui-config
can pull in elisp-demos
; but then it means crafted-ui-config
is not a fully independent module – it relies on loading crafted-early-init-config
or the user to configure MELPA manually.
Is this an intended behaviour?
Hi, thank you for opening an issue.
crafted-early-init-config
(for early-init.el
) and crafted-init-config
(for init.el
) are required modules. They configure the system to where crafted-emacs can be utilized (you can think of it as bootstrapping crafted-emacs).
So yes, crafted-
modules may or may not be dependent on these modules (e.g. you can't require
any crafted-emacs module without crafted-init-config
as it adds the path to the modules to loadpath).
Regarding your original question, the error seems to be in requiring the -packages
part of crafted-ui
after package-install-selected-packages
(missing from your init completely) and pulling in the crafted-ui-config
.
The section of the init.el
should probably look more something like:
;; Select packages
(require 'crafted-ui-packages)
;; Install selected packages
(package-install-selected-packages :noconfirm)
;; Load configurations
(require 'crafted-ui-config)
You also want to add the following to your early-init.el
(or create one and add it):
;; Path adapted from what your init.el used
(load "~/.config/crafted-emacs/modules/crafted-early-init-config")
Hope that helped to solve your issue. You can also look at the documentation, notably (place in the info buffer in parens):
docs/getting-started-guide.org
(Crafted Emacs ~> Getting Started)
docs/crafted-org.org
(Crafted Emacs ~> Modules ~> crafted-org)
I did notice the absence of explaining the early-init.el
configuration in Starting from an existing configuration
.
I think in general, the documentation around that is sparse/incomplete in explanations of how it works (yet) and of course there is still work to do on documenting the separate modules.
I understand it now. Thanks for the thorough explanation, @jvdydev!
I did notice the absence of explaining the early-init.el configuration in Starting from an existing configuration. I think in general, the documentation around that is sparse/incomplete in explanations of how it works (yet)
Perhaps open an issue so we can track this?
Hi,
Apparently,
elisp-demos
is required bycrafted-ui-config
, but Emacs doesn't seem to install it. I've checked the offending package and it's on MELPA (https://github.com/xuchunyang/elisp-demos) – which doesn't seem to be enabled by default? I've enabled MELPA in myinit.el
; however, I had to install it manually (M-x
package-list-packages
).Do I take it up with the package maintainer or perhaps it's not an intended behaviour (or is it?) and
crafted-ui-config
needs reviewing?Error (before enabling MELPA and installing
elisp-demos
):Init.el
:Specs: Emacs version: GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo version 1.16.0) of 2023-05-14, modified by Debian Distro: Debian Linux 12 (Bookworm) Kernel: 6.1.0-10-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.37-1 (2023-07-03) x86_64 GNU/Linux
Thanks, Ory