Closed hughjackson closed 1 year ago
I would actually prefer to go even further and unconditionally prefix these. Using the optional flags may work in some cases, and not in other cases. Also it seems odd to give the user control of this in the PeakRDL command line, when the tool should just do the "right" thing every time. Probably better to go all the way and fully prefix all the time:
<memoryMap>
gets imported as: <component name>_<memoryMap name>
<addressBlock>
gets imported as: <component name>_<memoryMap name>_<addressBlock name>
Its a little ugly, I kinda hate it, but it is the most robust defense against namespace collisions, especially when mixing multiple vendors with varying (and unpredictable) naming conventions.
I've made the prefixing unconditional as you suggest. I'm not sure if you wanted to leave the condition in the call to import_file and just remove from the peakrdl arguments though? That would at least ensure that any new release of this module would be backwards compatible. Sorry if I have misunderstood your feedback.
The combination of these options allows you to import two IPs with matching ipxact files where only the component name is different.