search

SystemRDL / PeakRDL-ipxact

Import and export IP-XACT XML register models
http://peakrdl-ipxact.readthedocs.io
GNU General Public License v3.0
31 stars 10 forks source link

initilize type_name and original_def vars #3

Closed bdmagnuson closed 4 years ago

bdmagnuson commented 4 years ago

I have a Verilog backend that utilizes type_name and original_def so units brought in via IP-XACT needs these variables set to something sensible rather than None.

amykyta3 commented 4 years ago

I'm not sure I agree with this change. I believe it should be up to the exporter to test whether type_name and original_def are None and act accordingly.

According to the compiler API reference, type_name can be left as None in situations where an importer cannot derive a type identifier. In the case of IP-XACT, the closest thing to a type name would be the <ipxact:typeIdentifier> tag (IEEE Std 1685-2014, section 6.11.7.2-a). Currently the importer does not process this tag.

Similarly, the original_def variable is specifically to denote that the current component was derived from a common definition. This is not the case when importing IP-XACT since each node is its own unique definition.