search

SystemRDL / PeakRDL-uvm

Generate UVM register model from compiled SystemRDL input
GNU General Public License v3.0
45 stars 25 forks source link

Added more features to the project #5

Closed muneebullashariff closed 3 years ago

muneebullashariff commented 4 years ago

Please find the added features and the corresponding commits.

amykyta3 commented 3 years ago

I cannot accept this pull request.

It is a mix of dozens of unrelated changes. Many of the features you have added are hard-coded behavior that is specific to your proprietary tools. There are also numerous changes that go against the philosophy of this project, changes that simply increase the complexity of the tool without adding any meaningful value, as well as outright syntax errors.

I apologize for being so blunt - but I cannot justify merging in such a collection of changes without any context, or explanation. If you think it would be helpful, I can go through your changes and comment on them individually and provide feedback, otherwise I will close this PR.

That said, I will still look at your contributions and see if there are any concepts that make sense to add to the official source.