Closed tuaris closed 3 years ago
What exactly did you needed to modify? Maybe we could merge it into the master - if the changes do not break the default instance?! :smile:
The changes I made patched the hard coded paths of the two files mentioned above (SQLite DB and pykms_config.pickle) to a r/w location that is outside the codebase (ie /var/run and /var/lib). Ideally there would be a CLI argument to specify those locations.
i created cli argument for database path, see #88. i don't know if is useful to create a cli for pykms_config.pickle, it's only a temp file to remember parameters.
чего за всех то говорить. Использовали и используют
@6ec123321 WTF dude? What is your point? We have someone here, which want to use FreeBSD. Fine. He also modified code so it works on his system (apparently that was not needed, because as @SystemRage already pointed out we have a parameter for that). I don't see any reason here to rant about pfsense (which I have never used, but may will in the future, because an own open-sourced router sounds good to me) nor I see any reason here to tell someone to "go to ass" nor to tell someone he is stupid. Please, when you drink you should probably not write stuff (I must admit drunken code is some kind of... interesting)... :no_mouth:
Russian FSB chek and black-listed FreeBSd for infiniti time ), black-hole detected in my country, we can make best weapon, you understand this "black-houle", i'm not understand what it meens, but they tell me "never using FreeBSD".
Ah, got it now! In that case it is may not the best idea to use it, BUT i think it greatly depends on the usage scenario: After all that system uses the Linux Kernel, which means basic functionality like the good old firewall works there too. Also when you are not exposing "badly programmed code", it should be fine? But imho you should not use any flawed systems in the open, but this is an other topic. Not meant for this issue 😁
i created cli argument for database path, see #88. i don't know if is useful to create a cli for pykms_config.pickle, it's only a temp file to remember parameters.
@SystemRage thanks for handling #88.
In regards to pykms_config.pickle
, the main issue is that it's created in the same directory where pykms is running. On Unix/Linux systems that directory may not be writable when following best security practices. Maybe it might make more sense to detect the OS's temp directory, (I think Python has that ability to do that via tempfile) and put the file in their?.
I hate to continue adding to the off topic conversation. I am not aware of anything in regards to FreeBSD being a security issue or being on any blacklists. It is frequently used and makes up the basis of systems throughout the IT world. Anyway each person is entitled to their opinion, but this is isn't the correct place to discuss. Thanks all.
I've made a FreeBSD port: https://github.com/tuaris/freebsd-py-kms
I doubt it will get included by default in the ports tree, but it's easy to build your own local package if you don't use Poureire
In order to get this working I had to patch a few things (all handled by the port).
pykms_Server.py
I had to change the location of the state file created by etrigan (pykms_config.pickle
).