Systems-Modeling / SysML-v2-Pilot-Implementation

Proof-of-concept pilot implementation of the SysML v2 textual notation and visualization
GNU Lesser General Public License v3.0
128 stars 24 forks source link

ST6RI-540 Space modeling additions #360

Closed conradbock closed 2 years ago

conradbock commented 2 years ago

These are the remaining space modeling capabilities (except bounding box orientation, taking as a separate issue for later). Slides at ST4MD-392 (May 16, 2022).

Occurrences.kerml

Added inner and outer occurrence references nested under Occurrence::spaceBoundary. These are space slices that also have no spaceBoundary, where the outer one surrounds the inner ones (see SurroundedBy below). Also added inverse constraint to spaceBoundaryOf.

Added associations from Occurrence to itself (indirectly) specializing OutsideOf:


Items.sysml

Generalized Item::envelopingShapes to cover curves and surfaces enveloping 2 dimensional shapes. Nested original constraint.

Added Item::boundingShapes specializing envelopingShapes as StructuredSpaceObjects in which every face/edge intersects the Item.

Added Item::voids as SysML name for innerSpaceOccurrences. Defined isSolid as having no voids.


CarWithEnvelopingShape.sysml

Replaced envelopingShapes with boundingShapes.


ShapeItems.sysml

Minor updates.

seidewitz commented 2 years ago

@hpdekoning Will you be able to review this?

conradbock commented 2 years ago

Should I update the various ::self to that (if it's being added in this ST6 sprint)? Eg, in the Items::envelopingShapes constraint Item::self would be that.that.

seidewitz commented 2 years ago

Should I update the various ::self to that (if it's being added in this ST6 sprint)? Eg, in the Items::envelopingShapes constraint Item::self would be that.that.

Not yet, since that isn't there yet. We can make revisions when once it is introduced. But let's get this PR done first.

conradbock commented 2 years ago

Looks like after all that work on JustOutsideOf I forgot to use it to replace WithinBoth in ShapeItems. Can I do this now? Very easy, just a text replace.

seidewitz commented 2 years ago

Looks like after all that work on JustOutsideOf I forgot to use it to replace WithinBoth in ShapeItems. Can I do this now? Very easy, just a text replace.

Sure, go ahead. I was going to merge this PR this morning, but didn't get a chance.

conradbock commented 2 years ago

OK, commited. Had to add a cross nav for mating in Occurrences, can update in TWC ST4MD-392 branch if you haven't merged it yet.

seidewitz commented 2 years ago

can update in TWC ST4MD-392 branch if you haven't merged it yet.

ST4MD-392 is not merged yet.