Systems-Modeling / SysML-v2-Pilot-Implementation

Proof-of-concept pilot implementation of the SysML v2 textual notation and visualization
GNU Lesser General Public License v3.0
114 stars 23 forks source link

ST6RI-724 Model library updates from SysML v2 FTF Ballot #9 #521

Closed seidewitz closed 7 months ago

seidewitz commented 7 months ago

This PR implements resolutions of issues from SysML v2 FTF Ballot 9 that called for updates to library models. In addition, it makes a further revision to TypeAdapter::removeUnnecessaryImplicitGeneralTypes (as already revised in PR #514) to ensure removal of implicit general types that are identical to explicit general types.

Resolutions of the following issues are implemented in this PR:

Resolutions of the following issues were previously implemented in PRs #487, #504 and #506:

Resolutions of the following issues did not require any update to the library model files:

An additional change was made later in PR #522 consistent with the preliminary resolution to the following issue:

conradbock commented 7 months ago
seidewitz commented 7 months ago

@conradbock

conradbock commented 7 months ago

but, instead, rely on semantic constraints determine their subsetting

Do these require all M0 values of subactions that are also values of sendActions will be values of sendSubactions, and vice versa?

And it is not actually necessary here, since these features are not modeled as "sufficient"

Sufficiency doesn't require declaring intersection. It can be used instead of intersection, it's just less well-defined.

the SysML notation does not support intersection.

I figured. :)

seidewitz commented 7 months ago

Do these require all M0 values of subactions that are also values of sendActions will be values of sendSubactions, and vice versa?

They require that all M1 send or accept action usages that are subactions of another action definition or usage subset sendSubactions or acceptSubactions. This may actually miss instances of SendAction and AcceptAction that are not declared using syntactic send or accept actions usages, but that is a general issue with the semantics constraints currently being based on syntactic structure, which can be addressed separately in the future.